BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!
Other
481 stars 235 forks source link

[Bug] Combat timer false positive when taking fall damage next to a mob #313

Open ghost opened 4 years ago

ghost commented 4 years ago

Describe the bug The combat timer incorrectly assumes that you are in combat when you take fall damage next to a mob

To Reproduce Steps to reproduce the behavior (how did you get this bug to occur):

  1. Ensure that you have a Intimidation Talisman (as the zombies in the hub are level 1, it prevents them from attacking you), and the feature Combat Timer Display on in SBA.
  2. In the SkyBlock Hub, head to the Graveyard.
  3. Use a grappling hook, ender pearls, or some other method to get high enough to take fall damage.
  4. Find where a zombie is, and fall as close to it as possible.

Once these steps are followed, the in combat timer will appear. However, you are still able to fast travel and open your menu while it is on screen.

Expected behavior The "IN COMBAT" timer does not appear, as fall damage does not cause the combat timer to start (you can still teleport while the timer is shown on screen).

Screenshots combat-bug

Crash Report N/A

System Information

Other Installed Mods If you have any other mods installed, please list them here along with their version number.

Additional info N/A

biscuut commented 4 years ago

Combat timer atm is mainly an estimation, and can't be 100% perfect due to the information the server gives us about damage (it isn't much). This is one of the false positives it causes ^^.

However I might still look into it eventually