BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!
Other
481 stars 235 forks source link

[Bug] Holograms can imitate power orbs in the power orb display #505

Open ILikePlayingGames opened 3 years ago

ILikePlayingGames commented 3 years ago

This issue was reported by Endergamer_hun and nopo on Discord.

Please note that we do not provide support for clients other than Forge. We will not fix compatibility issues with other clients.

Describe the bug When a hologram is placed with a power orb name and time remaining to imitate a power orb, the hologram will be shown in the power orb display.

To Reproduce Steps to reproduce the behavior (how did you get this bug to occur):

  1. Name a hologram with the name of a power orb and its time remaining, like "§5Overflux §e420s"
  2. Place the hologram
  3. The hologram shows up on the power orb display

Expected behavior The hologram shouldn't show up on the display.

Screenshots image.png

Crash Report If your game crashed, please paste the beginning of your crash report here. Copy from the beginning until the line shown below.

A detailed walkthrough of the error, its code path and all known details is as follows:

System Information

Other Installed Mods If you have any other mods installed, please list them here along with their version number.

Additional info Armor stand NBT:

Class: EntityArmorStand
Name: §5Overflux §e420s
NBT Data:
{
    NoGravity: 0b,
    HurtByTimestamp: 0,
    Attributes: [{
        Base: 20.0d,
        Name: "generic.maxHealth"
    }, {
        Base: 0.0d,
        Name: "generic.knockbackResistance"
    }, {
        Base: 0.10000000149011612d,
        Name: "generic.movementSpeed"
    }],
    Invulnerable: 0b,
    ShowArms: 0b,
    PortalCooldown: 0,
    AbsorptionAmount: 0.0f,
    FallDistance: 0.0f,
    DisabledSlots: 0,
    DeathTime: 0s,
    Pose: {
    },
    HealF: 20.0f,
    Invisible: 1b,
    Motion: [0.0d, 0.0d, 0.0d],
    Small: 0b,
    UUIDLeast: -4760465450654527692L,
    Health: 20s,
    Silent: 1b,
    Air: 300s,
    OnGround: 0b,
    Dimension: 0,
    Rotation: [0.0f, 0.0f],
    UUIDMost: -6234059879465398301L,
    CustomName: "§5Overflux §e420s",
    Equipment: [{
    }, {
    }, {
    }, {
    }, {
    }],
    Pos: [5.75d, 95.5d, 22.53125d],
    Fire: 0s,
    NoBasePlate: 0b,
    HurtTime: 0s,
    CustomNameVisible: 1b
}
Phoube commented 3 years ago

Lol of course Hypixel would add this to the game. Now we gotta check whether there's another armorstand near it that matches the texture url/skull id of the orb itself

ILikePlayingGames commented 3 years ago

Yes, that would be the most accurate way. I wonder if we can do it quicker by just checking if the armor stand is wearing a skull since holograms have no equipment.