search

BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!
Other
485 stars 237 forks source link

[Bug] Incompatible with april fools #693

Open oliverrook opened 1 year ago

oliverrook commented 1 year ago

Discord Username

No response

Bug Description

The mod doesn't recognize skyblock when it's april fools and thus doesn't enable.

SBA Version

1.7.2

Other Installed Mods

Optifine M5 NEU Skytils Cowlection Foamfix Scrollable Tooltips Patcher Danker's Skyblock Mod Hyblock RNG Analyzer

Operating System

Windows 10

Crash Report

No response

oliverrook commented 1 year ago

Skytils just updated and it changes the leaderboard title back to "Skyblock", thus fixing this issue

Noaaan commented 1 year ago

I did PR a fix for this particular issue, similar to what NEU does when checking if you are playing Skyblock: https://github.com/BiscuitDevelopment/SkyblockAddons/pull/692 While this hotfixes the issue, it does make you wonder if there is a good way to prepare for this next year, just in case the Skyblock devs realize the trolling potential (and rename SB again next year).