BitcoinDesign / Guide

A free, open-source community resource for designers, developers and others working on non-custodial bitcoin products.
https://bitcoin.design/guide/
Other
457 stars 98 forks source link

Usability and footer tweaks based on feedback #1085

Closed GBKS closed 5 months ago

GBKS commented 7 months ago

This addresses the super small easy-to-implement site feedback we got from Sven in the Open Source Design forum.

Since Nostr is not a single service, the link goes to Nosta, which is a service meant for showing Nostr profiles. I am also the creator of Nosta, so am I self-serving by doing this? Let me know what you think, we can change the link elsewhere.

Going to keep it as a draft since I want to look over the feedback again and make sure I captured everything that needs to go in this PR.

🩴Check the preview👠

netlify[bot] commented 7 months ago

Deploy Preview for bitcoin-design-site ready!

Name Link
Latest commit a3b16434915d78f795eac746e9312c8d5b940674
Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/6675431bbddcdd000856b7ed
Deploy Preview https://deploy-preview-1085--bitcoin-design-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mouxdesign commented 5 months ago

LGTM. using Nosta seems perfectly fine.

Footer links: I see that when I hover over the link the copy changes from black to orange. Upon click and returning to the page the copy remains black. Was there another hover (visited) state planned or perhaps it is not showing up on my end.

rabbitholiness commented 5 months ago

Looks good to me with one exception: I see the active state (orange) in the footer links, but not the visited state (like Mo mentioned as well).

Linking to Nosta is fine, I think.

GBKS commented 5 months ago

Thanks for the feedback. Can you please check again? I made a few tweaks.

mouxdesign commented 5 months ago

Works perfect! The visited links in the footer are now showing up as grey text, Screenshot 2024-06-21 122006