Blackberry0Pie / CoX-Scouter-External

Fork of the Runelite Chambers of Xeric plugin
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Screenshots not going to clipboard #2

Closed Skawtrs closed 4 years ago

Skawtrs commented 4 years ago

If you set the hotkey to say 's', you can no longer type 's' in game, however, it doesn't seem to copy any sort of screenshot to your clipboard and I do not see anything in any runelite folders where the screenshot was saved.

Blackberry0Pie commented 4 years ago

Maybe don't do that. Or set it to a modifier key + 's' eg "ctrl + s".

Skawtrs commented 4 years ago

...Right, but again, ctrl+s doesn't copy a screenshot to clipboard.

Skawtrs commented 4 years ago

No matter the key combo, nothing gets copied to clipboard.

Skawtrs commented 4 years ago

That was simply an example. Letting you know it's doing something, but not copying anything to clipboard.

Blackberry0Pie commented 4 years ago

I see. One issue seems to also occur for the standard RL plugin. Thanks for the bug report.

1) screenshot hotkey consumed when screenshot not taken: https://github.com/runelite/runelite/issues/12155

2) screenshot not taken: this.client.getVar() must be called on client thread

edited

Blackberry0Pie commented 4 years ago

v1.2 should fix the screenshot not being taken. I'll close this issue after the changes are approved, and release is tested as working. Edit: v1.2 released and tested as working.

I'll fix the same bug as #12155 after RL fixes the default plugin.