BlakeGuilloud / ganon

A javascript library
MIT License
92 stars 196 forks source link

Fix abbreviateMiddleName #764

Closed saelili closed 6 years ago

saelili commented 6 years ago

There is currently a method called abbreviateMiddleName that lives in /lib/abbreviateMiddleName.js. It is incomplete and needs to be fixed!

This function expects an input with three names (first, middle, last) and returns the full name with an abbreviated middle initial, properly capitalized. eg. 'Leslie Barbara Knope' should return 'Leslie B. Knope' eg. 'ann meredith perkeins' should return 'Ann M. Perkins'

Acceptance Criteria:

  1. Running yarn test <methodName> results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!