search

Blane245 / orchestration2

new orchestration
1 stars 1 forks source link

Melodic minor accidentals are incorrect #5

Closed Blane245 closed 2 months ago

Blane245 commented 2 months ago

Describe the bug The accidentals are occurring on the first note in the sequence but not on the subsequent octaves.

To Reproduce Steps to reproduce the behavior:

  1. Select any instrument that hase two or more octives in its range
  2. Select a melodic minor scale
  3. Select Ascending and Descending
  4. Observe sharps, flats, and naturals

Expected behavior All notes that have accidentals should have them for all octaves

Desktop (please complete the following information):

Blane245 commented 2 months ago

generated a full keyboard of accidentals from the key signature and changed getModifier to address this keyboard