search

Blizzard / heroprotocol

Python library to decode Heroes of the Storm replays
MIT License
398 stars 69 forks source link

Protocol decrease #78

Closed MGatner closed 5 years ago

MGatner commented 5 years ago

Today's PTR patch had an earlier protocol version than live - 71134 v. 71138. I know the whole version was larger, but since protocolXXXXX.py matches off the protocol only it made a mess of "protocol > current" type comparisons. This is the first time that has happened since I've been using heroprotocol - was this a mistake or something that could happen at any point?

Agilhardt commented 5 years ago

Heya @MGatner. I'm kind of surprised this hasn't happened before and it can definitely happen again. The build number is an atomic counter that ever increases regardless of how recent the code and protocols in the build are. If we generated a build today of Tech Alpha 6, it would have a higher build number than either the PTR or live build.

The build number has the apparent property of denoting recency but it's ultimately just a coincidence.

MGatner commented 5 years ago

Good to know! I will adjust accordingly, thanks for the prompt response.