search

Blizzard / s2protocol

Python library to decode StarCraft II replay protocols
MIT License
622 stars 111 forks source link

Fix imports in s2protocol cli script #89

Closed wroersma closed 5 years ago

wroersma commented 5 years ago

This makes it so the script is actually usable as a proper python package outside of the directory in git. If you do python setup.py install right now the script is broken. I would also be happy to convert the argparse to something like click which is much better to work with for CLI python applications in my opinion.

jrepp commented 5 years ago

Would you mind testing against the changes in #86? The imports are refactored in that PR and I have a feeling it may fix your use case.

wroersma commented 5 years ago

Absolute imports are the recommended standard to use for package imports. It's strongly discouraged to use explicit relative imports and this package is simply not complex enough to make a case to use them. So your PR would fix the issue I don't believe it would be the best solution.

jrepp commented 5 years ago

There were more import lines that needed to be covered, all from . relative imports have been converted to from s2protocol.

wroersma commented 5 years ago

Awesome thanks a ton for the hard work!