search

BlockchainCommons / seedtool-cli

Cryptographic Seed Tool for the command line
Other
25 stars 16 forks source link

linter: exclude style severity #56

Closed gorazdko closed 3 years ago

gorazdko commented 3 years ago

Abstract

cppcheck throws an error on new PRs (e.g. #53). I'm not sure why as these PRs don't introduce any (relevant) code, while master branch is considered OK by cppcheck.

Given that seedtool manual says warning severity suffices I'm suggesting to remove the style severity in this PR

make lint uses Cppcheck to perform static analysis on the code. All PRs should pass with no warnings.

See https://github.com/BlockchainCommons/bc-seedtool-cli/pull/54#issuecomment-811108198 for the 'warnings' issued by cppcheck

@wolfmcnally please advise

wolfmcnally commented 3 years ago

There is in fact a lint check error in the master branch. PR #57 fixes this. After this PR is merged, try the others again.

gorazdko commented 3 years ago

tnx, will do!