search

Blockchair / Blockchair.Support

Public repository for issues and feature requests. Submit your favorite bug!
420 stars 315 forks source link

Recognize BCH p2pool blocks #123

Open jtoomim opened 5 years ago

jtoomim commented 5 years ago

If a block's coinbase transaction includes a payout to qrgrmfhu5wgpvmgzp0sw0s52erx8pavyqvkhmltum6 (1Kz5QaUPDtKrj5SqW5tFkn7WZh8LmQaQi4), then that block was mined by p2pool.

https://forum.bitcoin.com/pools/p2pool-decentralized-dos-resistant-trustless-censorship-resistant-pool-t69932.html

Example: https://blockchair.com/bitcoin-cash/transaction/397077e4a41e51f963cd1704ba252e0b99359cc82ab50b6aa6df804dd49df4a2

The 1Kz5QaUPDtKrj5SqW5tFkn7WZh8LmQaQi4 address also indicates a p2pool block for BTC. On Litecoin, it's the same pubkey, but a different address (LeD2fnnDJYZuyt8zgDsZ2oBGmuVcxGKCLd).

Har01d commented 5 years ago

Sorry it takes that much time, but with our current architecture we can’t easily add a miner tag in case it’s neither in the coinbase data nor the address is in the first output of the coinbase transaction.

In case of p2pool (https://blockchair.com/bitcoin-cash/transaction/397077e4a41e51f963cd1704ba252e0b99359cc82ab50b6aa6df804dd49df4a2), the address (qrgrmfhu5wgpvmgzp0sw0s52erx8pavyqvkhmltum6) is in 23rd output.

We’ll be working on a workaround for that.

aguinaldok4 commented 2 weeks ago

/pR:#111209