search

Blockstream / electrs

An efficient re-implementation of Electrum Server in Rust
MIT License
324 stars 131 forks source link

Update rust-bitcoin to 0.25, elements to 0.13.0 #31

Closed fujicoin closed 3 years ago

fujicoin commented 3 years ago

We suggest updating rust-bitcoin to version 0.24.0 of the original repository.

dr-orlovsky commented 3 years ago

Why not 0.26?

fujicoin commented 3 years ago

Fixed an issue where liquid could not compile. It was necessary to update elements to 0.13.0, but with this it was necessary to update bitcoin to 0.25.

fujicoin commented 3 years ago

The latest TAG for rust-bitcoin is 0.25.2. So I think this update is OK. elements 0.13.0 specifies bitcoin 0.25 . The dependencies of TAG 0.14.0 and 0.15.0 are the same as 0.13.0. I haven't tried it, but I think it's possible to compile electrs with elements 0.15.0.

dr-orlovsky commented 3 years ago

Just FYI, rust-bitcoin has 0.26 release already (a week ago)

fujicoin commented 3 years ago

confirmed. The rust-bitcoin is certainly set to TAG 0.26.0 on January 15th. But don't use 0.26.0 ! This is because the liquid cannot be compiled because it is inconsistent with the depends of rust-elements.

dr-orlovsky commented 3 years ago

Ok, I heard they are working on updating liquid to 0.26 these days

fujicoin commented 3 years ago

I think it is better to separate esplora-electrs for bitcoin and liquid because coding becomes complicated.

shesek commented 3 years ago

I created a branch with rust-elements v0.15 and rust-bitcoin v0.26 (or v0.25 for liquid mode): https://github.com/Blockstream/electrs/commits/202101-deps

This will soon be merged to master.

fujicoin commented 3 years ago

OK. Then I will close this PR.