Changes to pysony.py - Githubissues

Bloodevil / sony_camera_api

sony camera remote api

http://developer.sony.com/develop/cameras/

MIT License

244 stars 60 forks source link

Changes to pysony.py #39

Closed qwe2tz closed 6 years ago

qwe2tz commented 6 years ago

Pep8 compliant
Added support for multiple versions of Sony SDK APIs
Maintaining legacy support

mungewell commented 6 years ago

Hi, can you please explain the benefit of having the 'version' string included in the command. I think this is to allow camera to understand the scope of what to return (ie. getEvent has multiple versions). I also note that some commands (ie. deleteContent) do not have a "version 1.0" equvilant.

Seems like a good idea, but can you break the patch down so that each part only has one purpose (clearer on what it does and enables cherry picking).

mungewell commented 6 years ago

Changes to 'class ControlPoint()' break the search technique used in the examples. Assumes a particular IP (rather than searching) and requires an additional 'search.connect()' call.

Fixed IP should only be used if end user sets one, I have cameras which show up on either 'http://10.0.0.1:10000' (QX10) or 'http://192.168.122.1:8080' (HX60).

For a better search technique checkout the patch on: https://github.com/Bloodevil/sony_camera_api/issues/31