Improvements to SSDP discovery and associated tests

bjmc commented 5 years ago

I was running into some errors using the SSDP discovery ControlPoint() with my camera, so this is an attempt to clean up and improve the SSDP discovery logic.

The two main changes in pysony.py are:

Don't break out of the loop early in _listen_for_discover() -- I think this was the source of my bug, because it wasn't listening long enough to get the response from my camera.
Use XML libraries to parse the device definition file, instead of regex. I think this should be a lot easier to maintain and more reliable across different camera models.

I've also added tests for SSDP discovery, including some dummy services to test against, and updated the README to include docs on running tests.

There's some minor overlap with #57, but I think the conflicts will be easy to resolve.

bjmc commented 5 years ago

This might help with #33 if their issue is the same timeout problem as mine.

bjmc commented 5 years ago

This might also fix #23 since one of the comments theorizes the issue is with the regular expression parsing.

bjmc commented 5 years ago

Changed base branch to develop -- is that right @Bloodevil?

Bloodevil commented 5 years ago

Changed base branch to develop -- is that right @Bloodevil?

yep it is right. thanks!

Bloodevil commented 5 years ago

I merge it to develop.

Bloodevil / sony_camera_api

Improvements to SSDP discovery and associated tests #58