Bloodevil / sony_camera_api

sony camera remote api
http://developer.sony.com/develop/cameras/
MIT License
244 stars 60 forks source link

_cmd Method from pysony.py is missing minversion variable #62

Closed raza-elahi closed 4 years ago

raza-elahi commented 5 years ago

Method signature

def _cmd(self, method=None, param=[], target=None)://Line 283, pysony.py

Adding the variable with a default value of 1.0 to the method works.

It also does not have the verison variable.

final signature looks like

def _cmd(self, method=None, param=[], target=None, version=1.0, minversion="1.0")

danielrosero commented 4 years ago

Method signature

def _cmd(self, method=None, param=[], target=None)://Line 283, pysony.py

Adding the variable with a default value of 1.0 to the method works.

It also does not have the verison variable.

final signature looks like

def _cmd(self, method=None, param=[], target=None, version=1.0, minversion="1.0")

Thanks, this helped me a lot.

I was facing this issue: TypeError: _cmd() got an unexpected keyword argument 'version'

Bloodevil commented 4 years ago

thanks all! i added version and min version to develop branch. I'll merge and update soon. :)