Remove VecStim to use the version in neurodamus-models - Githubissues

BlueBrain / neurodamus

A BBP Simulation Control application for NEURON

https://neurodamus.readthedocs.io

Apache License 2.0

9 stars 8 forks source link

Remove VecStim to use the version in neurodamus-models #177

Closed WeinaJi closed 4 months ago

WeinaJi commented 4 months ago

Context

VecStim.mod exists in both neurodamus and neurodamus-models which is not good to maintain. For the PR https://github.com/BlueBrain/neurodamus-models/pull/8 where we plan to replace VecStim.mod with vecevent.mod, we will remove VecStim.mod in neurodamus.

Scope

Remove VecStim.mod. libsonata v0.1.27 works with numpy 2.0, so bump the version in our github actions pipeline.

Review

[x] PR description is complete
[x] Coding style (imports, function length, New functions, classes or files) are good
[ ] Unit/Scientific test added
[ ] Updated Readme, in-code, developer documentation

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217598 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217653 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217678 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217690 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217853 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217905 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #217908 (:no_entry:) have been uploaded here!

Status and direct links:

WeinaJi commented 4 months ago

I'd like to merge this PR before tagging the new release. @jorblancoa @ferdonline, does it look good to you?

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #218129 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #218128 (:white_check_mark:) have been uploaded here!

Status and direct links: