Closed joni-herttuainen closed 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9479090
) 100.00% compared to head (de5cda6
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great idea, looks good to me. I didn't go through all the schema to make sure it's correct though...
Can't blame you. It's a whole lot of schemas. I followed the spec religiously, so it should (barring possible mistakes made by me) condone to that but I'm only like 99.9% sure.
If people start using this, they will eventually find any possible discrepancies between the validation and the spec. I hope there aren't too many of them. Validator is not a validator if it validates incorrect things 😅
Added schema based validation for simulation configurations.
validate-simulation
validate
in favor ofvalidate-circuit
BluepySnapDeprecationWarning
It would also make sense to further the config values, such as
and possibly add the option to also run the circuit validation for the circuit used in the simulation (provided that
network
is defined).But all of the other features should be added in a separate PR, this one is big enough as it is.