search

BobRay / UpgradeMODX

A dashboard widget that detects upgrades and (optionally) installs them from within the MODX Manager
https://bobsguides.com/upgrade-modx-package.html
22 stars 14 forks source link

UpgradeMODX 2.3.1 and MODX 2.8.3 #74

Open Jako opened 2 years ago

Jako commented 2 years ago

The current version of UpgradeMODX shows the following widget in the frontend:

Screenshot

Version 3 is disallowed, this is fine. But the widget shows the begin upgrade button, even if there is no further version in the 2.x branch.

BobRay commented 2 years ago

Good point, but I'm not sure how to handle this situation. You've always been able to "upgade" to the version you already have, so this just makes it easier. On the other hand, it's not a real upgrade. And should "Upgrade Available" and "Latest Version" 3.0.0-pl" be showing with ugm_show_modx3 off or not? Suggestions welcome.

Camo30 commented 2 years ago

In my opinion "Upgrade Available" and "Latest Version: 3.0.0-pl" should not be shown when ugm_show_modx3 is disabled.

BobRay commented 2 years ago

I agree, but it may be difficult given the way that the current version is identified. I'll try to find time to look into it.