search

BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.49k stars 1.95k forks source link

Right to Left direction does not affect the callouts #5104

Closed okaeiz closed 4 months ago

okaeiz commented 4 months ago

Describe the Bug

When I create an RTL callout, the callout box is rendered LTR (the icon is displayed on the left).

Capture

Steps to Reproduce

  1. In the Persian UI, select a text, change its direction to RTL and change its style to Callouts.
  2. It is the same as when the text direction is LTR.

Expected Behaviour

I expect the callout box to be rendered accordingly.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.05.1

ssddanbrown commented 4 months ago

Thanks for reporting @okaeiz. I've now addressed this for most scenarios via commit 95c3cc5c00fefe954481129caa68f6bf6bad5f7a. Where more modern CSS support (or RTL support) is lacking (old browsers, export formats) these may still default back to RTL display. This will be part of the next patch release.