search

BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

boostnote doesnt mount storage due to invalid note #2763

Open chartotu19 opened 5 years ago

chartotu19 commented 5 years ago

Current behavior

None of the Storages are mounted. Console error log shows:

screenshot from 2018-12-28 03-09-09 Further investigation shows a invalid note "notes/a82d153d-69b1-4781-8280-e0bfdda82924.cson" with the following content is breaking the for loop.

'content':  ''

The iOS boostnote app however is able to list all the notes successfully.

Expected behavior

The storage should be mounted by ignoring the invalid note. Some sort of user alert will be helpful. Since the note has no usable information, I think automatically deleting it should also be acceptable. Thoughts?

Steps to reproduce

Not sure how the note was created in the first place. I use boostnote on macOS, debian, iOS with storage synced via dropbox. I am certain that the note was created on debian or macOS.

Environment

daiyam commented 5 years ago

@chartotu19 could you try the last version?

chartotu19 commented 5 years ago

nope, doesnt work with 0.11.12 as well. I bypass this issue by deleting the note, then everything works fine (on both versions). I believe boostnote should ideally skip over the note for successful app init.

daiyam commented 5 years ago

@chartotu19 are you using Dropbox to synchronize your notes?

chartotu19 commented 5 years ago

@daiyam yup, I am using Dropbox.

daiyam commented 5 years ago

@ZeroX-DG the issue seems to be related to this line: boostnote-mobile/app/views/note/DropboxNoteModal.js, line 18

MiloTodt commented 5 years ago

A fix like this may help

https://github.com/BoostIO/Boostnote/pull/2794