search

BosNaufal / react-scrollbar

The Simplest Scroll Area Component with custom scrollbar for React JS. https://bosnaufal.github.io/react-scrollbar
MIT License
71 stars 30 forks source link

Webpack dev server settings fixing #3

Closed usulpro closed 8 years ago

usulpro commented 8 years ago

Hello, I tryed to start dev server but it not working (maybe because I work under windows?) So here some small changes wich helped me to run it

usulpro commented 8 years ago

And the last commit is for using inline style for main scrollarea div

BosNaufal commented 8 years ago

Thank you for the pull request! it's awesome~ :grin:
But something that I don't know is, why we should add inline style while the props for className has existed?

usulpro commented 8 years ago

I wanted to make it in a separate pull request, but it went together. So it just for flexibility. Due to that REACT supports both variants of styling as inline or via css and it's so easy to implement. For somebody it may be convenient to use one or the other option, besides, they can be used together (for example if u use some scrollareas in one page)

BosNaufal commented 8 years ago

Got it! Thank you so much for your contributions @UsulPro. I'm waiting for your collaboration in next open source project :grin:

usulpro commented 8 years ago

Oh sure. Thank you :smile: And do you have plans to develop this project? I would have participated, because I like it and I want to use it in my work

BosNaufal commented 8 years ago

@UsulPro, Please come in :grin: I would like to thank to you! I'll appreciate any contributions to this project~ :+1: