search

Box-Of-Hats / Bem-VSCode-Extension

A VSCode extension for helping with inserting BEM (Block-Element-Modifier) classes.
BSD 3-Clause "New" or "Revised" License
29 stars 5 forks source link

Insert Element - Attribute Insert misbehaviour #12

Closed zeshanshani closed 4 years ago

zeshanshani commented 4 years ago

Possibly misbehavior. When you Insert Element and then press TAB the 2nd time, it takes you to the attribute place, however, it takes it to both opening and closing tags (see: https://s.zeshanahmed.com/a_234B8580.png). I think it was meant to take only to the opening tag?

Box-Of-Hats commented 4 years ago

This is intended. For the reason that the closing tag needs to match the opening tag. If only the opening tag was selected then it would be possible to open a <H1> tag with a </div> closing

zeshanshani commented 4 years ago

@Box-Of-Hats I explained that one as well in separate issue: #11

Box-Of-Hats commented 4 years ago

I've just released version 0.8.0 of the extension which includes a slight change in the insert element snippets.

Has this fixed this issue for you?

zeshanshani commented 4 years ago

@Box-Of-Hats yes, it works perfectly. Thanks a lot! 👍