search

Box-Of-Hats / Bem-VSCode-Extension

A VSCode extension for helping with inserting BEM (Block-Element-Modifier) classes.
BSD 3-Clause "New" or "Revised" License
29 stars 5 forks source link

allow _modifier-name #13

Closed furtivite closed 4 years ago

furtivite commented 4 years ago

Thanks for plugin. Version: 0.7.5

My settings of plugin looks like

{ "editor.largeFileOptimizations": false, "explorer.confirmDragAndDrop": false, "editor.minimap.enabled": true, "window.zoomLevel": 0, "explorer.confirmDelete": false, "terminal.integrated.shell.windows": "D:\\Program Files\\Git\\git-bash.exe", "terminal.external.windowsExec": "D:\\Program Files\\Git\\git-bash.exe", "git.enableSmartCommit": true, "git.confirmSync": false, **"bemHelper.modifierSeparator": "_"** }

and extansion setting looks like 2019-10-08_09-35-02.

By default BEM metodology uses _ as .modifierSepararor link. But if I configure the plugin as above, it does not work correctly, and emphasizes classes with modifier because it considers ` _ ' as part of the class name. 2019-10-08_09-39-44

Box-Of-Hats commented 4 years ago

Thanks for the detailed bug report. I'll look into this issue later today

Box-Of-Hats commented 4 years ago

Thanks for bringing this up. I've now fixed this bug and it is available in the 0.8.0 release of BEM Helper.

Let me know if you find any more bugs

mr9d commented 4 years ago

Thank you for the quick fix, sir!

furtivite commented 4 years ago

Thanks, it's fixed. Super fast.