search

BoxOfDevs / CommandShop

Players have to pay items or money to use specific commands! A PocketMine plugin.
Other
31 stars 10 forks source link

CommandShopUI!! #10

Open nasiridrishi opened 6 years ago

nasiridrishi commented 6 years ago

Brief description

Its not an issue but it would be awesome if you can dev it as UI based command shop!!

Steps to reproduce

  1. ...
  2. ...
  3. ...

Expected result

Actual result

Server Information

CrashDumps/Errors

Paste your CrashDump or error by replacing this text (DON'T delete the backticks!)
HimbeersaftLP commented 6 years ago

You aren't the first with that idea, but I'll be waiting for PMMP's integrated to be merged to master

AvgZing commented 6 years ago

Actually, I'll try to start teaching the BOD team how to efficiently make UIs. This isn't too hard to do.

HimbeersaftLP commented 6 years ago

@TheRoyalBlock I know you can directly use JSON, but I'd rather use the API because we won't have to change that much if MCPE changes the format.

AvgZing commented 6 years ago

Erm.... There is an API...

HimbeersaftLP commented 6 years ago

Nope

HimbeersaftLP commented 6 years ago

https://github.com/pmmp/PocketMine-MP/pull/1476 Still W.I.P.

AvgZing commented 6 years ago

It's possible to make a UI https://github.com/thebigsmileXD/WarpUI https://github.com/PlexusStudio/WorldTpUI

HimbeersaftLP commented 6 years ago

The first one uses a nonexistent function on a Player object (probably made for a fork?) The second one uses a super complicated method to do it manually (as I said above you can directly use JSON)

AvgZing commented 6 years ago

The WorldTpUI one is not complicated, I can explain it.

AvgZing commented 6 years ago

And the second one uses both of these:

https://github.com/thebigsmileXD/customui https://github.com/thebigsmileXD/WarpUI

HimbeersaftLP commented 6 years ago

The WorldTpUI one is not complicated, I can explain it.

I know how it works, it's just a lot of code which wouldn't be needed of we could use a builtin API and that has to be updated every time Mojang decides to change something.

AvgZing commented 6 years ago

Mojang changes it less frequently than Pocketmine does, and we already update this plugin every time pocketmine changes

HimbeersaftLP commented 6 years ago

How about we just make our code for the unfinished API? It's surely not going to take a decade for that PR to get merged.

Mojang changes it less frequently than Pocketmine does

*cough* *cough*

AvgZing commented 6 years ago

I'm not so sure about that... Many PM PRs take weeks or even months... But good idea!

HimbeersaftLP commented 6 years ago

Even if we knew it will take months, we could just make the base plugin, and if the pr still isn't merged, it isn't that hard to add our own UI implementation. So, should CommandShopUI be a seperate plugin?

AvgZing commented 6 years ago

Yea

Artistic-Waffle commented 6 years ago

lol yeah

LeoBdt commented 5 years ago

???? news?

HimbeersaftLP commented 5 years ago

When the rewrite is finished, making a CommandShopUI plugin that uses the new CommandShop API should be fairly easy.