Brain-WP / BrainMonkey

Mocking utility for PHP functions and WordPress plugin API
https://giuseppe-mazzapica.gitbook.io/brain-monkey/
MIT License
304 stars 29 forks source link

WP Helper functions: ensure parameter names are in line with WP Core #136

Closed jrfnl closed 1 year ago

jrfnl commented 1 year ago

... for compatibility with code under test using PHP 8.0+ function calls with named arguments.

For some of these functions, WP has renamed the parameter(s) over the past year or so, for some, the names were never in line.

Even though WP Core doesn't necessarily officially support the use of named parameters in function calls, that (of course) won't stop people from using them and their tests should not break on that due to BrainMonkey not being in line with WP for parameter names.

gmazzap commented 1 year ago

Thank you @jrfnl!