BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
234 stars 144 forks source link

Build fails when using plugin version 4.2.2 #682

Closed noahcooper closed 3 years ago

noahcooper commented 3 years ago

The most recent version of this plugin causes build to fail with this error:

ENOENT: no such file or directory, copyfile '/Users/noah.cooper/my-mobile-app/branch.json' -> '/Users/noah.cooper/my-mobile-app/platforms/android/app/src/main/assets/branch.json'

It looks like this is caused by the new hook added in e2fdf307d5f2c04d48caaee937f1c7b247fc11d5.

Downgrading back to 4.2.1 fixes this.

MaximBelov commented 3 years ago

you can check this fix https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/pull/683

noahcooper commented 3 years ago

This is still broken in 4.2.3.

echo-branch commented 3 years ago

Please use the workaround provided by @MaximBelov It's merged, but missed the hotfix for Android. Totally forgot about it. It will be in the next release.

echo-branch commented 3 years ago

This should be fixed in the 4.2.4 patch release.