search

BrandenEK / Blasphemous.LostDreams

Miscellaneous performance improvements
4 stars 6 forks source link

RB506 effect code and placeholder sprite for vfx #93

Closed EltonZhang777 closed 1 month ago

EltonZhang777 commented 1 month ago

Completes code for RB506

Adds placeholder sprite for its vfx

Added the PenitentSwordAttackEvent in EventHandler

EltonZhang777 commented 1 month ago

All suggestions taken care of. Using an array for the projectiles was a design oversight, but could be actually useful if the cooldown of the projectiles are short enough or the projectiles last long enough time, so that they might be multiple projectiles in-game at once. Judging from this perspective, using array is actually more convenient for future code reuse on similar effects.

BrandenEK commented 1 month ago

All suggestions taken care of. Using an array for the projectiles was a design oversight, but could be actually useful if the cooldown of the projectiles are short enough or the projectiles last long enough time, so that they might be multiple projectiles in-game at once. Judging from this perspective, using array is actually more convenient for future code reuse on similar effects.

I wouldn't call it an oversight, I just think it is more complicated than it needs to be. It is useful if there are multiple projectiles at once, so it is good to leave it that way.