search

BreadMoirai / github-release-gradle-plugin

A Gradle Plugin to send Releases to Github
Apache License 2.0
108 stars 26 forks source link

Release is done before artifacts are uploaded #28

Open maxandersen opened 4 years ago

maxandersen commented 4 years ago

When using this plug-in the Only artifacts listed in notifications are the source zip and tar. Additional artifacts are only visible on the release page.

Feels like it's releases immediately rather than create draft releases then upload artifacts and then mark as releases.

BreadMoirai commented 2 years ago

GitHub doesn't assign a tag to the release until it's published for some reason and so there isn't any way for us to figure out what release we want to upload artifacts to. This normally wouldn't be a problem for the simple use case as we do get the link to the release when we create it initially but for more complex systems that upload artifacts using a CI on a different process, we would have to do something janky like just looking for the most recent draft. Not sure the best way to approach this.