BrettMayson / HEMTT

Build System for Arma 3
https://brettmayson.github.io/HEMTT
GNU General Public License v2.0
109 stars 40 forks source link

Configurable Optionals #65

Closed jonpas closed 4 years ago

jonpas commented 5 years ago

addons is static anyways, as Arma 3 requires that.

However, optionals is completely custom, we could easily allow custom name for it and even allow more than 1 optionals folder.

BrettMayson commented 5 years ago

In my opinion, optionals has become a defacto standard that we can rely on / enforce. I would rather see customization for optionals through the HEMTT project file.

jonpas commented 5 years ago

Project file is what I was going for.

I agree, just thought of it as some people might have a different name.

Multiple optionals folders would make sense to separate compatibility patches from additional functionality and things like that.

BrettMayson commented 5 years ago

we could try getting compats going, with optionals for additional functionality and compats for compatibility mods

jonpas commented 5 years ago

But that is exactly why I would make it configurable and allow array input for the configuration. We don't have to care about how people split them then.

BrettMayson commented 5 years ago

While I generally agree that as much as possible should be configurable, I think we should have addons, optionals, and compats as 3 "supported" folders, and projects like ACE can then choose to move their compats and have it be fully supported and functional.

In addition to that, there is no reason we can't have a configurable array of folders, that simply get built during hemtt build. The HEMTT CLI should only support --opts cool_feature --compats yawm. Otherwise, it would become cluttered with flags to specify which addon from which folder.

jonpas commented 5 years ago

Agreed.

BrettMayson commented 4 years ago

What are your thoughts on this? I'm kinda thinking of closing this. The first party support for optionals and compats seems good enough in my opinion. I can't see any reason why someone would have addons outside of those.

jonpas commented 4 years ago

I think it's fine as it is. I still don't really like enforcing separation into optionals and `compats due to their nature, but that can be solved with #197.