Brewskey / spark-server

An API compatible open source server for interacting with devices speaking the spark-protocol
https://www.particle.io/
GNU Affero General Public License v3.0
54 stars 27 forks source link

Include Bunyan Logger in Spark-Server #218

Closed haeferer closed 7 years ago

haeferer commented 7 years ago

This includes

haeferer commented 7 years ago

I've changed and answered your questions

cu

Andreas

AntonPuko commented 7 years ago

You need to rebase all you prs to last dev

haeferer commented 7 years ago

@AntonPuko : Seems i survived my first rebase (hopefully) :) . Can you please double check if everthing is correct

haeferer commented 7 years ago

I've lost some changes, i need some minutes

haeferer commented 7 years ago

finished.

haeferer commented 7 years ago

please check

AntonPuko commented 7 years ago

No man, idk what you have done but with normal rebasing we shouldn't see previous not related with the diff changes

haeferer commented 7 years ago

I've done rebasing with git rebase (commandline)

haeferer commented 7 years ago

how can i help?

AntonPuko commented 7 years ago

@haeferer https://github.com/Brewskey/spark-server/pull/224 this how rebased commit should look like, so please do rebase right way or create new clean PRs. We can't accept this. And please, squash your commits, it's too many of them.

haeferer commented 7 years ago

Closed,

failed on rebase