search

Brewskey / spark-server

An API compatible open source server for interacting with devices speaking the spark-protocol
https://www.particle.io/
GNU Affero General Public License v3.0
54 stars 27 forks source link

package-lock.json is not up to date #229

Closed haeferer closed 7 years ago

haeferer commented 7 years ago

"Bunyan and other packages missing" is based on an old package-lock.json file.

As a first workaround, after git clone, remove this file!

haeferer commented 7 years ago

I think it's based on this

https://github.com/npm/npm/issues/16580#issuecomment-301973529

AntonPuko commented 7 years ago

just make sure that you recreate and commit fresh package-json.lock every time you change deps in package.json

haeferer commented 7 years ago

How do you force a recreate. Documentation of NPM means : done automatic during save install etc. But it doesnt work in my side. Which version of NPM do you use

AntonPuko commented 7 years ago

npm 5.0.4 1) rm -rf node_modules 2) delete package-lock.json 3) npm i 4) commit package-lock.json

haeferer commented 7 years ago

i think there is a problem with the current LTS Version of node (6.11.0) with NPM 3.10.10 :( NPM 5 starts with node 8... (at least at the standard packages)

I will take a look into this.

I would prefer (for my images) to stay, for now, on the LTS Version

AntonPuko commented 7 years ago

i guess npm 3.10 doesn't use package-lock.json at all, so it shouldn't affect older versions.

haeferer commented 7 years ago

i will check this in the evening on my Mac Installation. Maybe the problem was a mixup with the sparc-protocol bug https://github.com/Brewskey/spark-protocol/issues/126