search

BrianClement / Demo2

Test repository for syncing with local VS repository
0 stars 0 forks source link

DOC: add a few details on installing build prerequisites._U #54

Open BrianClement opened 7 years ago

BrianClement commented 7 years ago

[Issue originally created 2017-Mar-22 00:47:19 UTC by rgommers]

BrianClement commented 7 years ago

[Comment originally created 2017-Mar-22 01:06:05 UTC by rgommers]

I assume the change to ES6 is fine? ES5 gave lots of errors like:

Using TypeScript 2.1.6 from P:\Documents\code\discbot-discview\discview\node_modules\typedoc\node_modules\typescript\lib
Error: P:/Documents/code/discbot-discview/discview/node_modules/@angular/common/src/pipes/async_pipe.d.ts(43)
 Cannot find name 'Promise'.
Error: P:/Documents/code/discbot-discview/discview/node_modules/@angular/compiler/src/aot/compiler.d.ts(31)
 Cannot find name 'Promise'.
BrianClement commented 7 years ago

[Comment originally created 2017-Mar-27 20:40:28 UTC by rgommers]

The idea with pull requests is that someone merges them .....

@racleave I'm not 100% sure about the ES5 to ES6 change, does that look fine to you?