search

BrianHenryIE / strauss

Prefix PHP namespaces and classnames to allow multiple versions of libraries to exist without conflict.
https://brianhenryie.github.io/strauss/
MIT License
142 stars 23 forks source link

Is there a way to control the permission of the vendor-prefixed folder? #104

Closed estevao90 closed 5 months ago

estevao90 commented 6 months ago

Starting in v0.16.0, the permission of the vendor-prefixed folder was changed to 0600. I think it's related to this commit, and it's not intentional.

Is there any chance to use (0755) as default again? Or maybe introduce a parameter to allow us to change the permission?

The default value for the vendor folder is 0775. 0600 is very restrictive and may cause issues in servers managed by groups.

Thank you.

BrianHenryIE commented 6 months ago

Fixed in master https://github.com/BrianHenryIE/strauss/commit/c9fa47e48196a044b55b69b978c5cf653628f271

estevao90 commented 5 months ago

@BrianHenryIE, do you have a forecast for when you will release it?

BrianHenryIE commented 5 months ago

That is released now in 0.19.2. Thanks.

estevao90 commented 2 months ago

@BrianHenryIE , I just figured out another related issue.

The subfolders in vendor-prefixed do not have the correct permissions.

Looking at the code, we need to set visibility for the copied folders in this part https://github.com/BrianHenryIE/strauss/blob/master/src/Copier.php#L84

estevao90 commented 1 month ago

@BrianHenryIE , any update on it? Thanks!