search

BridgesUNCC / bridges-python

Python client library for Bridges
http://bridgesuncc.github.io
MIT License
2 stars 4 forks source link

add_edge properties are attached to the list of edges instead of the edge's link visualizer #69

Open acbart opened 4 years ago

acbart commented 4 years ago

The following code is meant to create an Edge with the label "Gamma", but does not do so.

graph = GraphAdjList()
graph.add_vertex("A", label='Alpha')
graph.add_vertex("B", label='Beta')
graph.add_edge('A', 'B', label='Gamma')

However, the following addition will update the label successfully:

graph.get_edge('A', 'B').label = 'Delta'

It seems to be a result of the following code:

https://github.com/BridgesUNCC/bridges-python/blob/35ff7b342193e6ffb850aa3e6b2333241bd7be1b/bridges/graph_adj_list.py#L118

I'm pretty sure these arguments should be passed to the Edge constructor instead of to the SLElement.

krs-world commented 4 years ago

Yeah, I think you are right.. we have moved  some of these functionalities to the Edge object and this has been left behind.

    --- krs

On 4/9/20 1:03 PM, Austin Cory Bart wrote:

The following code is meant to create an Edge with the label "Gamma", but does not do so.

graph= GraphAdjList() graph.add_vertex("A",label='Alpha') graph.add_vertex("B",label='Beta') graph.add_edge('A','B',label='Gamma')

However, the following addition will update the label successfully:

graph.get_edge('A','B').label= 'Delta'

It seems to be a result of the following code:

https://github.com/BridgesUNCC/bridges-python/blob/35ff7b342193e6ffb850aa3e6b2333241bd7be1b/bridges/graph_adj_list.py#L118

I'm pretty sure these arguments should be passed to the Edge constructor instead of to the SLElement.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-python/issues/69, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFEOG4OKWETUL7EYSACHTRLX5X3ANCNFSM4ME4H46A.

--

Kalpathi Subramanian Ph: 704 687 8579 Associate Professor Email: krs@uncc.edu Dept of Computer Science Web:http://webpages.uncc.edu/krs The University of North Carolina Charlotte, NC 28202-0001

AlecGoncharow commented 4 years ago

Should work as intended now

krs-world commented 4 years ago

Alec, did you also check the other two versions (C++ and Java) to ensure they are fixed, as needed? I assume the issue brought up by Cory was in Python?

    -- krs

On 4/10/20 11:38 AM, Alec Goncharow wrote:

Should work as intended now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-python/issues/69#issuecomment-612084347, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFEOFOU3XXFT7W4Z26UD3RL44OFANCNFSM4ME4H46A.

--

Kalpathi Subramanian Ph: 704 687 8579 Associate Professor Email: krs@uncc.edu Dept of Computer Science Web:http://webpages.uncc.edu/krs The University of North Carolina Charlotte, NC 28202-0001

AlecGoncharow commented 4 years ago

This isn't an issue in the other languages, as the other clients don't provide the ability to add visual properties in the addEdge method arguments.