search

Brightspace / D2L.CodeStyle

Annotations and analysis tools for D2L C# code style
Apache License 2.0
10 stars 22 forks source link

Moving pinning attributes and the pinned analyzer #921

Closed alamarre closed 1 year ago

alamarre commented 1 year ago

This could be broken up into a couple PRs. Either way we'll want bring in the analyzer before switching the attributes and removing the analyzers from the LMS. The recursive pinned analyzer in the LMS isn't where we'll want it to be, due to not incorporating changes that prevent it from erroring immediately so we can remove that from the LMS before bring in the new one.

I also refactored what's in the LMS repo to clean it up a bit and start from the symbol rather than the syntax node.

alamarre commented 1 year ago

This could be broken up into a couple PRs.

Doing so after discussion of changing must be recursively pinned to must be deserializable.

omsmith commented 1 year ago

Just for reference - curious why we're moving these here from the LMS? I'm assuming its so they can be used in D2L.Core or something?

alamarre commented 1 year ago

Just for reference - curious why we're moving these here from the LMS? I'm assuming its so they can be used in D2L.Core or something?

That is the primary driver. It could be handled in another way, but it also does enforce that the analyzers run on all the LMS libraries in a way that's not easily / accidentally undone.

j3parker commented 1 year ago

Has this PR been descoped? It looks like the analyzer is no longer included

alamarre commented 1 year ago

Has this PR been descoped? It looks like the analyzer is no longer included

Yes, as per my comment on the 11th due in part to the renaming of the one attribute.