BrowserSync / browser-sync

Keep multiple browsers & devices in sync when building websites. https://browsersync.io
https://discord.gg/2d2xUThp
Apache License 2.0
12.19k stars 757 forks source link

chore: updated notify types to match from IBrowserSyncOptions #2093

Open bgturner opened 2 weeks ago

bgturner commented 2 weeks ago

I was using BrowserSync within a different package and noticed that the types for the notify indicate that it's only a boolean:

Screenshot 2024-11-12 at 10 02 56 AM

But it looks like the IBrowserSyncOptions interface has the notify key accepting a CSS styles object or array of CSS style rules.

I'm not as familiar with this project, so I just copied the type definition, but when I run a diff between the InitOptions and IBrowserSyncOptions, it looks like they're mostly the same except for InitOptions having:

    userPlugins: any[];
    session: number;

Screenshot 2024-11-12 at 11 18 58 AM

Should the types between these two things the same, or should we consider importing and extending IBrowserSyncOptions?