search

Brunel-Visualization / Brunel

Brunel Visualization
Apache License 2.0
290 stars 77 forks source link

Bidi defects in mirroring #275

Open ragabo opened 6 years ago

ragabo commented 6 years ago

Mirroring is not fully supported for visualization.

Steps to produce:

  1. Change browser language (content language) to any right-to-left language (Arabic/Hebrew).
  2. Launch python/examples/Whiskey.ipynb.

Here are the findings:

  1. Y-axis for bar visualization is not mirrored. mirroring_bar_yaxis

  2. Bubble visualization is not mirrored.

    • Slider is not mirrored.
    • Rate indicator text is overlapped with icons.
    • Checkbox is overlapped with text item in drop down list. mirroring_bubble_slider

  3. White title (representing category) in treemap is not aligned properly. mirroring_treemap_rtl

GBR-613 commented 6 years ago

Should be fixed with: https://github.com/Brunel-Visualization/Brunel/pull/266

ragabo commented 6 years ago

I added changes from #266 into my local env. and rebuilt brunel with gradle, then I ran notebook again, but nothing fixed. @GBR-613 Please advice.