Closed jdumas closed 2 years ago
Fantastic Jeremie ! To make it clear, if I merge this pull request, it will start continuous integration directly ? There is nothing else to configure ?
Yes I believe so. In the repo setting page you have some options related to github actions. By default it will require you to "approve" first-time contributors before running any action coming from a fork pull request.
To facilitate CMake maintenance, I'd recommend the following:
configure.sh
andconfigure.bat
. Platforms can be detected directly via CMake (see new filegeo_detect_platform.cmake
.cmake/platforms.cmake
, which seems like a pain to maintain. I'd recommend keeping a singleplatforms/Windows.cmake
and a singleplatforms/Unix.cmake
and usecheck_cxx_compiler_flag
to check for compiler support for specific flags across all possible GCC/clang versions.Continuous PR check:
Nightly check: