search

BrunoLevy / geogram

a programming library with geometric algorithms
Other
1.9k stars 129 forks source link

source tarball for 1.8.2 doesn't build as the tests dir is missing #40

Closed svenstaro closed 2 years ago

svenstaro commented 2 years ago

Executing cmake naively, I get 

CMake Error at CMakeLists.txt:144 (add_subdirectory):
  add_subdirectory given source "tests" which is not an existing directory.

The reason is that the tests/ directory appears to be missing from the release tarball despite it being in this repository. I assume this is a packaging problem when assembling the release source package.

BrunoLevy commented 2 years ago

Fixed (replaced the tarball in the release). Thank you very much for notifying.

svenstaro commented 2 years ago

That's cool but please never replace a released tarball. This is always greatly confusing to distro packagers. Please just make a new release instead, even if there are no other code changes in there.

BrunoLevy commented 2 years ago

OK.