Budibase / budibase

Low code platform for building business apps and workflows in minutes. Supports PostgreSQL, MySQL, MariaDB, MSSQL, MongoDB, Rest API, Docker, K8s, and more 🚀
https://budibase.com
Other
22.83k stars 1.58k forks source link

Update Setting Filtering to -> "No flinters set" even when filters have been set #14947

Closed mikesealey closed 3 weeks ago

mikesealey commented 3 weeks ago

Checklist

Hosting

Describe the bug In an existing app that has a cards-block, "Update Setting" conditions are added to change filtering. In the app, there are 6 cases where filtering is updated, all of which have filters established, but all rows show "No filters set".

Showing no fitlers set

image

When clicking into "no filters set", filters exist

image

To Reproduce Steps to reproduce the behaviour: Unable to create a fresh app where this occurs - I believe it may be to do with the way v3 Filter Groups interact with established filters.

Expected behavior Button should reflect how many filters are already set.

Screenshots https://jam.dev/c/b3d99d34-1bdb-463c-a182-ea761efb61ff

App Export App-export available on request

Desktop (please complete the following information):

Additional context Issue discovered in a customer's app

linear[bot] commented 3 weeks ago

BUDI-8815 Update Setting Filtering to -> "No flinters set" even when filters have been set

aptkingston commented 3 weeks ago

This is almost certainly due to the logic that is counting the filters not accounting for the old structure. It's harmless in that it shouldn't affect functionality, but is very misleading. I can take a look at it.