Private notes

[carletex]

It's useful to have a private note field for admins.

We have to consider "security" implications. We don't want to leak the private notes. Maybe we can use firestore subcolletctions... or just not return that field from any query (except for the "admin review" one)

To add the private note

Maybe it can be on the "edit grant" modal

To show the private note

We can show it (in small text) below on the GrantReview (For proposed ones)

e.g.

even with a diff color

[andrealbiac]

To add some (unsolicited but maybe useful) feedback, I think to me it makes sense to show it in black, maybe even 75% opacity? Like a dark grey. I think in red looks a bit like an error message

Also a little title like 'Notes' would be cool!

[carletex]

We want the notes to be highlighted since grants with private notes are the ones that might need to be processed first (a few admins are looking at the grants). If we do the same color, you will scroll and not see the notes easily (thinking about UX, not UI :))

I think in red looks a bit like an error message

We don't want to look like an error, but a warning.

I agree that red might be too strong, but black & black 75% opacity will bury the notes.

We can tinker with it when Shiv makes the PR!

[andrealbiac]

Oh right! Okay sorry I misunderstood the feature, thought this was a note from the admins to the grant owner but it's just for admins! Then it makes sense that you want to highlight it as a warning & in red👌🏻

[carletex]

Sorry, I probably wasn't clear in the issue description (Since I talked about this before with Shiv).

I might send you some color options when the PR is ready tho.

Thanks!

[andrealbiac]

No worries!

Okay cool 🙌🏻 no pressure though :) just here if you need me

[carletex]

Closed on #117