Closed technophile-04 closed 1 month ago
vercel[bot]
commented
1 month ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| grants-bg | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 14, 2024 5:08am |
technophile-04
commented
1 month ago Are the signatures equal in length? (Probably they are for EOA vs 1/n Safe).
| Safe sig 1/2 | After |
|---|---|
So yeah their length seems same and we are not able to distinguish
Are we getting something else back or it's safe injecting something in the page? (maybe it won't work if we wallet connect into the app, without the frame)
The thing it could be connected via walletconnect breaks all the approaches. I tried getting current connected connector from wagmi's useAccount hook but when you connect via walletConnect it just only shows walletConnect and don't give more details like walletConnect was used via safe or MM
Also while digging found this https://ethereum.stackexchange.com/a/141258 where one of the Safe developer answered and he too seems to tell to check if connected address is contract or not
It seems like it's not checking correctly if the address is a contract to execute the new safe logic. The log I'm getting:
Ohh thanks @Pabl0cks! Just fixed it at https://github.com/BuidlGuidl/grants.buidlguidl.com/pull/135/commits/6373ec43bc74bd5f829005bcacdb2a5380756c9b
Description
Updated all the routes where we were doing admin check:
Demo signing with admin :
https://github.com/user-attachments/assets/77b5f2fb-c8fc-4283-b854-35f838708493
Demo with contract interaction( there was this transaction notification that transaction hash not found in background but everything seems to work, maybe some problem in sepolia etherscan because my trasactions was also taking time)
https://github.com/user-attachments/assets/faa6d29e-9080-4b6d-99df-64c5e1a337fd