Open ntbrown opened 6 months ago
cathawk
commented
4 months ago @ntbrown I am currently in the process of looking into errors on our website:
Failed to execute 'querySelectorAll' on 'Document': 'div:has(> iframe[id='198230182308109283091823098102938908128390'])' is not a valid selectorand have come across this. Can you let me know how you suspect those are coming from Chrome Extension errors? Any idea what the idea is referring to?
ntbrown
commented
4 months ago @ntbrown I am currently in the process of looking into errors on our website:
Failed to execute 'querySelectorAll' on 'Document': 'div:has(> iframe[id='198230182308109283091823098102938908128390'])' is not a valid selectorand have come across this. Can you let me know how you suspect those are coming from Chrome Extension errors? Any idea what the idea is referring to?
I don't see how this is related to the main issue.
How you suspect those are coming from chrome extension errors
I've made no indication of this in the original post. My original post is for loading the sequence of scripts via the HubSpot script loader failing on the conversations embed when attempting to load things through the partytown library
If you are attempting to build some form of chrome extension related to the conversations embed that is beyond the scope of this issue
Any idea what the idea is referring to
This is a better fit for stack overflow
nativeB
commented
3 months ago @ntbrown facing this exact issue now, any lead on what's going on here? hope you can point me in the right direction
ntbrown
commented
3 months ago @ntbrown facing this exact issue now, any lead on what's going on here? hope you can point me in the right direction
@nativeB
Sorry I don't.
This issue was opened to log the issue. That's it. I haven't looked at this even once since.
It's on partytown to provide broader support or HubSpot in my eyes w/ respect to resolution whether it be they need to fix their scripts for support and / or provide guidance on integration if configuration suffices
I would point out that partytown is still in beta and it is not meant to be a seamless integration for every random thing. Hence issues.
Although I would point out that the entire intent of the package is aimed exactly at the problems platforms like HubSpot /marketing in general cause which is a bit ironic in hindsight
Regardless:
For the latter.... Lol.... Don't hold your breath. Plenty of devs are still waiting on HubSpot to fix 5+ year old issues amongst other things.
And, I personally, have no interest in fiddling with it for a company I have no respect for given the egregiously poor impact on accessibility and the Internet as a whole they've contributed to - not to mentioned what I consider to be egregiously unethical marketing to small businesses leaving them holding the bag with malformed technical assets due to issues much like this one - in my humble opinion.
FYI for anyone reading this in the future. Partytown is the last of your problems.
Their auto-injected analytics (GA, ...) also need patching for logging back/forward cache distinctions, more appropriate loading - which partytown can address if you do some questionable templating hacks, amongst other things,
Frankly, I think products like this are doomed to fail from the outset so I don't think this is really worth visiting. No matter how much you tidy things up marketing will just bungle it again.
And, even if you did, I would very much like to point out this is just perceived performance which I think a lot of us have forgotten is not the same as real performance (ie - not loading X megabytes of JS crap in the first place)
Just because you are shifting debt doesn't mean that it does not exist.
Solutions like Zaraz etc are the way forward imo but aren't exactly what one considers seamless and getting compliance for them / abidance is not exactly what I would call painless.
So you really have to question what the utility in going to this much effort to make lighthouse look prettier really is
Describe the bug
TL:DR; -- Throws on hubspot.require and attempting to define newrelic.
Per title when a HubSpot portal uses the chat widget provided the script loader will includes scripts of the form:
Upon attempting to load and process said scripts you will get a few errors centered around the
bundle.production.jsfile the chat widget scripts attempt to load.Specifically:
Which references this line
function I(e,t){return f(t)?function(r){return t(r,e)}:t}function N(){(thi$(this)?window:this)._hasJSON=!("object"!=typeof JSON||!JSON.stringify)and
which errors on:
hubspot.require(['enviro', 'PortalIdParser']and