BuildingSync / BuildingSync-gem

Other
2 stars 1 forks source link

Think through section floor area #156

Open haneslinger opened 9 months ago

haneslinger commented 9 months ago

When generating an OSM for building, we check that the sections square footage totals to that of the building. If it does not, we error out.

currently we only test buildings with zero or one sections. This leaves us open to many untested and (and often error filled) cases in which a building has multiple sections, such as

  1. the sections overlap, and therefore, their square footage does not total to that of the building
  2. one or more of these sections do not specify their square footage 3 one or more of the sections is excluded

This issue is further exacerbated by the fact that if they section is missing it square footage, we assume it is that of the buildings

We need to decide as a group if

  1. if a section square footage is missing, it's safe to assume that it's that of the buildings

  2. the buildingsyncgem should be able to handle multiple sections

  3. if so, flush out the logic for it the section square footage does not total to that of the buildings. (Ie, error out, exclude sections, ect)