BullyWiiPlaza / JMaster-Duel-Bot

A mod and bot for Yu-Gi-Oh! Master Duel (Steam version)
https://www.youtube.com/watch?v=EBuDqRFmSQI
120 stars 13 forks source link

Logic Improvements #18

Open pwm9ypa1rtu0vcw-FHG opened 1 year ago

pwm9ypa1rtu0vcw-FHG commented 1 year ago

Seeing as the Nurse Burn is the only real deck this bot supports, the surrender logic could use a lot of work. For example, if somebody Harpie Feather Duster's our entire board - just surrender. If somebody Infinite Impermanence's at the end of our trap chain and there's no Bad reaction to Simochi to counteract it - just surrender. If Ash Blossom & Joyous Spring interrupts a crucial card draw effect and makes lethal impossible, surrender. Even if this is just a toggle option. Watching over the bot there I've seen so many games where manually surrendering because of these cards has saved a minute of my opponent endlessly comboing and then eventually auto surrendering anyway because of turn time.

Another mechanic of Infinite Impermanence (negate the activation of traps in this column) should be taken into account when placing traps in the same column. The chance to avoid this could be increased if we use these columns for our junk spell cards when trying to clear our hand for Card of Demise.

I've also seen the deck use the last card in hand - Pot of Duality - while a Nurse was already on the board, and instead of taking Upstart Goblin it took another Banishment of the Darklords + Nurse and discarded the entire hand, losing the duel by 2000 LP. If it would've taken Upstart Goblin there would've been another chance at drawing a card that might've dealt the final 1000 LP.

And last - it would be great if there was some kind of support for Ring of Destruction in the Nurse burn deck. Seeing as it's supported in Self Burn, and the couple of duels that I've tried using Ring of Destruction (before I realized the bot would never play it and took it out of the deck), it would've won the duel if it was used at the correct time on the correct monster.

BullyWiiPlaza commented 1 year ago

Hi, thanks for the feedback. Another good and cheap deck to run is the self burn deck. Unlike what most people think, it's pretty effective for farming since it can complete missions easily and you progress your duel pass as well as getting some wins and random gem drops.

It's expected that the bot has some bugs or less optimal plays, it's never going to be perfect. The bot follows a set rule of plays and card priorities which will not be optimal in all scenarios, especially when it comes to interactions with the opponent which are already minimal. Since people just use it for farming and not winning championships, it serves its purpose. 👍

I'll still fix things if they are reasonably easy to fix, though which is making Ring of Destruction usable in Nurse Burn. However, there was still a bug with it which caused the bot to get stuck while trying to target the opponent's monster with Ring of Destruction. That's another issue with running the card right now. You can already use Secret Barrel for example which is similarily good. Ring of Destruction cannot be used to finish off the opponent either due to the errata.

pwm9ypa1rtu0vcw-FHG commented 1 year ago

Oh cool, I didn't see Secret Barrel on the card list but that's good to know. If we're going for a FTK, IDK if that's worth having over some of the other traps that I already have. That'd be like 1400 LP max.

I just had a similar but different Pot of Duality issue too - lost a duel by 1000 LP where a Nurse was already on the field, because it prioritized Into the Void over Upstart Goblin.

Thanks for reading my feedback and for the reply. I used to bot World of Warcraft and Hearthstone in the Honorbuddy days, it's always been cool watching how optimized some of these profiles get over time

BullyWiiPlaza commented 1 year ago

I implemented the Upstart Goblin Pot of Duality priority changes to make it pick that card instead when it can burn the opponent. I also added Ring of Destruction support. Detecting the column for Infinite Impermance is currently not easily possible, the same for Ash or similar card activations by the opponent. The bot update for it will be released later. About the improved surrender option, I think that also isn't worth the effort.