search

Bungie-net / api

Resources for the Bungie.net API
Other
1.22k stars 92 forks source link

Heroic Strike Milestone marks as incomplete on completion #343

Open dcaslin opened 6 years ago

dcaslin commented 6 years ago

A partially complete Heroic milestone like here: https://www.bungie.net/Platform/Destiny2/1/Profile/4611686018431413708/?components=Profiles,Characters,CharacterProgressions will properly return progress (this user is 1/3 done, note progress = 1)

"3405519164": {
                            "milestoneHash": 3405519164,
                            "availableQuests": [
                                {
                                    "questItemHash": 2173086903,
                                    "status": {
                                        "questHash": 2173086903,
                                        "stepHash": 862259013,
                                        "stepObjectives": [
                                            {
                                                "objectiveHash": 1834636033,
                                                "destinationHash": 2512542997,
                                                "activityHash": 0,
                                                "progress": 1,
                                                "complete": false
                                            }
                                        ],
                                        "tracked": false,
                                        "itemInstanceId": "6917529045661259827",
                                        "completed": false,
                                        "redeemed": false,
                                        "started": true
                                    }
                                }

Compare to a fully complete user, where the stepObjectives become empty but the milestone is not complete, https://www.bungie.net/Platform/Destiny2/1/Profile/4611686018434964640/?components=Profiles,Characters,CharacterProgressions: 

"3405519164": {
                            "milestoneHash": 3405519164,
                            "availableQuests": [
                                {
                                    "questItemHash": 2173086903,
                                    "status": {
                                        "questHash": 2173086903,
                                        "stepHash": 0,
                                        "stepObjectives": [],
                                        "tracked": false,
                                        "itemInstanceId": "0",
                                        "completed": false,
                                        "redeemed": false,
                                        "started": false
                                    }
                                }
                            ],
                            "startDate": "2017-12-12T17:00:00Z",
                            "endDate": "2017-12-19T17:00:00Z"

Disclaimer: After the weekly reset these examples won't necessarily work with live data

vthornheart-bng commented 6 years ago

Ah, thank you for reporting this! I will investigate further.