search

Bunn / Xgist

Xcode extension to send code to GitHub's Gist
MIT License
77 stars 5 forks source link

Keychain access #10

Closed Bunn closed 7 years ago

Bunn commented 7 years ago

The extension should only ask for keychain access when signing in or if the user has a token stored. Currently it will ask on the first run since GitHubAPI().isAuthenticated is executed to define what options the extension should display to the user on SourceEditorExtension.swift

insidegui commented 7 years ago

I don't think this will happen on a signed release version of the app. The keychain dialog only appears when the app/extension is not signed or the signature has changed.

Bunn commented 7 years ago

Oh, cool. That's good to know, thanks @insidegui