BurgerLUA / burgerstation

My main project. This is the repository for the upcoming BYOND game Burgerstation. Currently in development.
Other
39 stars 119 forks source link

Makes it so examining your skills/attributes with more survival levels gives you tips about them #695

Closed Gboster-0 closed 3 days ago

Gboster-0 commented 3 months ago

What this PR does

Makes it so skills/attributes by default have very vague descriptions, with your survival expirience increasing the detail in them. Also adds in a framework for adding tips to skills/attributes, also locked behind survival expirience of course

The survival skill required to unlock the description of a skill/attribute was chosen by taking how early you level it up, and only 2 of the same number exist in the same file.

Currently the tips are: SKILL_MELEE

SKILL_BLOCK

SKILL_SUMMONING

Why it should be added to the game

Currently survival does not do what it states on the tin, and i think it would be neat adding in tips to skills that tell you about obscure things

BurgerLUA commented 2 months ago

I'm a little conflicted with making the survival skill give information that's already available. I intended it to be used for stuff like examining the current health value of mobs, and not something that anyone can just look up on the repo. The updated descriptions are nice though.

Gboster-0 commented 3 days ago

I'm a little conflicted with making the survival skill give information that's already available. I intended it to be used for stuff like examining the current health value of mobs, and not something that anyone can just look up on the repo. The updated descriptions are nice though.

Thats my plan for it for another PR, but imo some of these would be very usefull to have in-game and something that would be annoying to search up, or some more minor tips as most people will never touch the github code.

What i did with blocking and summoning is give the actual end result of calculations of how many minions you have, or how much your blocking is multiplied by via your skills. This is annoying to calculate.

I basically also seperated skill examines into 3 categories that are not really relevant to the PR itself