search

ButterCMS / buttercms-ruby

Ruby API client for ButterCMS (https://buttercms.com)
Other
25 stars 21 forks source link

Ruby 2.7 Warnings #17

Closed HamptonMakes closed 3 years ago

HamptonMakes commented 3 years ago

Given that you are on Ruby 2.7, the buttercms-ruby gem triggers the following warning:

lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete

More information: https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string

jakelumetta commented 3 years ago

Thanks @hcatlin ! We'll look into this.

HamptonMakes commented 3 years ago

Definitely makes my test runs a little... crowded.


/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
...{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}
/Users/hcatlin/.rvm/gems/ruby-2.7.2/gems/buttercms-ruby-1.8/lib/buttercms-ruby.rb:75: warning: URI.escape is obsolete
.{:preview=>nil}```
jakelumetta commented 3 years ago

@hcatlin Sorry for the delay. If you happen to have a chance to create a PR for this, happy to review it.