Closed orlyohreally closed 2 years ago
@orlyohreally @prokopsimek This issue card has been broken up into individual issues and assigned as to-do cards on the following project board: https://github.com/orgs/ButterCMS/projects/1, so I'm closing this issue here.
GATSBY_
prefixThis is an example blog post
query and found none although it's a start of post body. While reviewing the code I found out that we search only by post titles https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/templates/blog.js#L25. Is it what we want? This note goes with the previous note so maybe search functionality will be redone altogether. Also minor note: why use 'm' flag for regex on post titles?false
by default (should be true in my opinion)package-lock.json
file after runningnpm run install
? Also, I needed to installeslint
to run this repo locallykey
as index ofmap
is not a good practice, so since tags' slugs should be unique we could makekey
to equal to tag slug? https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/templates/article.js#L49. Similar thing in these places: https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogPostsList.js#L18 https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogPostsList.js#L31 https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogSection.js#L26 https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogWidget.js#L21BUTTER_CMS_API_KEY
andBUTTER_CMS_PREVIEW
? https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/.env.example#L1useState
https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/containers/Layout.js#L24query
https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogWidget.js#L11useState
https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/Spinner.js#L6